-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PID as an attribute in each sample #212
base: main
Are you sure you want to change the base?
Conversation
Hi @bhavnajindal, can you please also sign the CLA? |
Hi, I have initiated the process of signing the corporate CLA through my organization - IBM. Awaiting approval from the CLA manager. |
Note that we're about to introduce a new collector reporter, that will ultimately replace this OTLP one. |
@dmathieu Is there a feature branch available for the new collector reporter. |
@bhavnajindal Just in case you prefer generics, there is a solution (feel free to use). It still requires a type switch, but you don't need to return error from |
@rockdaboot Thank you for your solution. I had almost reached the same solution yesterday but my in-experience with go kept me from fully realizing the solution. I learnt a good deal from your code. Thanks again. |
What:
This PR aims to add process Id as an attribute for each sample. This would be an addition to other attributes such as containerId, threadName etc. being sent currently.
Why:
Tools/services consuming the profiles sent by opentelemetry-ebpf-profiler could utilize the PID as an identifier for a process in their software/implementations.