Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PID as an attribute in each sample #212

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

bhavnajindal
Copy link

@bhavnajindal bhavnajindal commented Oct 28, 2024

What:
This PR aims to add process Id as an attribute for each sample. This would be an addition to other attributes such as containerId, threadName etc. being sent currently.

Why:
Tools/services consuming the profiles sent by opentelemetry-ebpf-profiler could utilize the PID as an identifier for a process in their software/implementations.

@bhavnajindal bhavnajindal requested review from a team as code owners October 28, 2024 19:17
Copy link

linux-foundation-easycla bot commented Oct 28, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@christos68k
Copy link
Member

Hi @bhavnajindal, can you please also sign the CLA?

@bhavnajindal
Copy link
Author

Hi @bhavnajindal, can you please also sign the CLA?

Hi, I have initiated the process of signing the corporate CLA through my organization - IBM. Awaiting approval from the CLA manager.

@dmathieu
Copy link
Member

Note that we're about to introduce a new collector reporter, that will ultimately replace this OTLP one.

@bhavnajindal
Copy link
Author

@dmathieu Is there a feature branch available for the new collector reporter.

@dmathieu
Copy link
Member

#208

reporter/otlp_reporter.go Outdated Show resolved Hide resolved
reporter/otlp_reporter.go Outdated Show resolved Hide resolved
@rockdaboot
Copy link
Contributor

rockdaboot commented Nov 5, 2024

@bhavnajindal Just in case you prefer generics, there is a solution (feel free to use). It still requires a type switch, but you don't need to return error from addProfileAttributes().

generics.txt

@bhavnajindal
Copy link
Author

@rockdaboot Thank you for your solution. I had almost reached the same solution yesterday but my in-experience with go kept me from fully realizing the solution. I learnt a good deal from your code. Thanks again.

reporter/otlp_reporter.go Show resolved Hide resolved
reporter/otlp_reporter.go Outdated Show resolved Hide resolved
reporter/otlp_reporter.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants